Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full simplify arguments in function calls #326

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Full simplify arguments in function calls #326

merged 1 commit into from
Feb 9, 2024

Conversation

sharkdp
Copy link
Owner

@sharkdp sharkdp commented Feb 9, 2024

Before this, we would get non-simplified outputs sometimes:

>>> floor(1.2 hours / hour)

      = 1 h/h

We can't do this after the function call, because otherwise we wouldn't be able to have functions like:

fn f(ratio: Scalar) = ratio -> cm/m

@sharkdp sharkdp merged commit 23d8a27 into master Feb 9, 2024
15 checks passed
@sharkdp sharkdp deleted the full_simplify_for_function_calls branch February 9, 2024 16:25
@GreyTeardrop GreyTeardrop mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sharkdp